[ 
https://issues.apache.org/jira/browse/LUCENE-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12502957
 ] 

Hoss Man commented on LUCENE-930:
---------------------------------

Damn, i forgot to include these comments from Steven regarding the patch...

This patch file removes the swallowed failures by doing more of the build steps 
out of the guarded loop (that only detects junit failures, not others).

In addition the patch, need to create and "svn add"
A contrib/wordnet/src/test
A contrib/similarity/src/test
A contrib/lucli/src/test

This makes it possible to actually run the gdata-server tests, which were not 
running before. I have seen one case where it hung, but maybe that was a fluke.

> fail build if contrib tests fail to compile
> -------------------------------------------
>
>                 Key: LUCENE-930
>                 URL: https://issues.apache.org/jira/browse/LUCENE-930
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 2.1
>            Reporter: Hoss Man
>         Attachments: LUCENE-930.patch
>
>
> spinoff of LUCENE-885, from Steven's comments...
> Looking at the current build (r545324) it looks like the some contrib 
> failures are getting swallowed. Things like lucli are throwing errors along 
> the lines of
>  [subant] /home/barronpark/smparkes/work/lucene/trunk/common-build.xml:366: 
> srcdir "/home/barronpark/smparkes/work/lucene/trunk/contrib/lucli/src/test" 
> does not exist!
> but these don't make it back up to the top level status.
> It looks like the current state will bubble up junit failures, but maybe not 
> build failures?
> ...
> It's "test-compile-contrib" (if you will) that fails and rather being 
> contrib-crawled, that's only done as the target of "test" in each contrib 
> directory, at which point, it's running in the protected contrib-crawl.
> Easy enough to lift this loop into another target, e.g., build-contrib-test. 
> And that will start surfacing errors, which I can work through.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to