[ https://issues.apache.org/jira/browse/LUCENE-930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man updated LUCENE-930: ---------------------------- Attachment: LUCENE-930.patch (FYI: the javacc thing was ared herring) ok, i am 99% sure this patch is *GOLDEN* ... it should take care of everything Steven pointed out, and more. What this this patch does... High Level... * "build-contrib" now calls a new "build-artifacts-and-tests" target on every contrib (previously it just called the default target) ... any failures in any contrib fail the build. * "test-contrib" now depends on "build-contrib" ... along with the previous point, this solves addresses the crux of the issue Steven noticed. * By default, the compile-test and test targets of contribs without tests do nothing (previously they failed because of a missing directory) * cleanup of the build files for various contribs so that various dependencies work better. Details... * changes to contrib-build.xml... * add a build-artifacts-and-tests target * better support for "build-lucene" (executed in proper directory now) * new support for "build-lucene-tests" * test and compile-test now do nothing if the contrib has no tests * changes to gdata-server build.xml... * test now depends on compile-test * added build-artifacts-and-tests (because it can't import contrib-build.xml) * adds explicit compile-core, compile-test, and build-artifacts-and-tests targets to the db build.xml (meta-contrib can't use the ones inherited from contrib-build.xml) * clean up the bdb, bdb-je, and benchmark build.xml files so their init targets depend on the contrib-build init target (and doesn't skip up to common.init) * change spellchecker build.xml so it's compile-test depends on build-lucene-test (it compiles against English.java) * main build.xml ... * build-contrib now contrib-crawls build-artifacts-and-tests * test-contrib depends on build-contrib I'll try to do some more testing of various build target permutations tomorrow -- particularly under java 1.4 -- but i'd appreciate it if other people could try beating on it as well > fail build if contrib tests fail to compile > ------------------------------------------- > > Key: LUCENE-930 > URL: https://issues.apache.org/jira/browse/LUCENE-930 > Project: Lucene - Java > Issue Type: Bug > Components: Build > Affects Versions: 2.1 > Reporter: Hoss Man > Assignee: Hoss Man > Attachments: LUCENE-930.patch, LUCENE-930.patch, LUCENE-930.patch, > LUCENE-930.patch > > > spinoff of LUCENE-885, from Steven's comments... > Looking at the current build (r545324) it looks like the some contrib > failures are getting swallowed. Things like lucli are throwing errors along > the lines of > [subant] /home/barronpark/smparkes/work/lucene/trunk/common-build.xml:366: > srcdir "/home/barronpark/smparkes/work/lucene/trunk/contrib/lucli/src/test" > does not exist! > but these don't make it back up to the top level status. > It looks like the current state will bubble up junit failures, but maybe not > build failures? > ... > It's "test-compile-contrib" (if you will) that fails and rather being > contrib-crawled, that's only done as the target of "test" in each contrib > directory, at which point, it's running in the protected contrib-crawl. > Easy enough to lift this loop into another target, e.g., build-contrib-test. > And that will start surfacing errors, which I can work through. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]