[
https://issues.apache.org/jira/browse/LUCENE-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524084
]
Ning Li commented on LUCENE-847:
--------------------------------
> Not quite following you here... not being eligible because the merge
> is in-progress in a thread is something I think any given MergePolicy
> should not have to track? Once I factor out CMPW as its own Merger
> subclass I think the eligibility check happens only in IndexWriter?
I was referring to the current patch: LogMergePolicy does not check for
eligibility, but CMPW, a subclass of MergePolicy, checks for eligibility. Yes,
the eligibility check only happens in IndexWriter after we do Merger class.
> Rename to/from what? (It is currently called MergePolicy.optimize).
> IndexWriter steps through the merges and only runs the ones that do
> not conflict (are eligible)?
Maybe rename to MergePolicy.findMergesToOptimize?
> > The reason I asked is because none of them are used right now. So
> > they might be used in the future?
>
> Both of these methods are now called by IndexWriter (in the patch),
> upon flushing a new segment.
I was referring to the parameters. The parameters are not used.
> Factor merge policy out of IndexWriter
> --------------------------------------
>
> Key: LUCENE-847
> URL: https://issues.apache.org/jira/browse/LUCENE-847
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Reporter: Steven Parkes
> Assignee: Steven Parkes
> Fix For: 2.3
>
> Attachments: concurrentMerge.patch, LUCENE-847.patch.txt,
> LUCENE-847.patch.txt, LUCENE-847.take3.patch, LUCENE-847.take4.patch,
> LUCENE-847.txt
>
>
> If we factor the merge policy out of IndexWriter, we can make it pluggable,
> making it possible for apps to choose a custom merge policy and for easier
> experimenting with merge policy variants.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
