[ https://issues.apache.org/jira/browse/LUCENE-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12525802 ]
Michael McCandless commented on LUCENE-847: ------------------------------------------- > Is there any reason not to make ConcurrentMergeScheduler the default too > after this is committed? Good question. The only downsides I can think of are: * It's all fresh code so until we let it "age" some, it's a higher risk that something broke. That said there is decent unit test coverage for it and these unit tests did find some sneaky issues (which I fixed!). * It only actually helps on machines that have some concurrency. But in this case we are largely talking about IO concurrent w/ CPU which nearly all machines have I think. I think the benefits are sizable: * Good performance gains (25% speedup of net indexing time for all of Wikipedia content -- details in LUCENE-870) * Trivial way to leverage concurrency (ie you don't need to manage your own threads). * No more unexpected long pauses on certain addDocument calls. So I think it would make sense to make it the default. I'll include that in the new issue for changing defaults in IndexWriter. > Factor merge policy out of IndexWriter > -------------------------------------- > > Key: LUCENE-847 > URL: https://issues.apache.org/jira/browse/LUCENE-847 > Project: Lucene - Java > Issue Type: Improvement > Components: Index > Reporter: Steven Parkes > Assignee: Steven Parkes > Fix For: 2.3 > > Attachments: concurrentMerge.patch, LUCENE-847.patch.txt, > LUCENE-847.patch.txt, LUCENE-847.take3.patch, LUCENE-847.take4.patch, > LUCENE-847.take5.patch, LUCENE-847.txt > > > If we factor the merge policy out of IndexWriter, we can make it pluggable, > making it possible for apps to choose a custom merge policy and for easier > experimenting with merge policy variants. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]