Hi Doron, > On the other, the logic of "use memory-limit unless added-docs-limit was > specified" seems somewhat confusing
The design intention is to use either maxBufferedDocs/maxBufferedDeleteTerms or ramBufferSize, but not both at the same time. > (why only by pending adds, why not also by pending deletions?). You are right. MaxBufferedDocs and maxBufferedDeleteTerms should be used in a similar way, but they are not - maxBufferedDocs cannot be used with ramBufferSize while maxBufferedDeleteTerms can. I'll open an issue. > In addition, I saw the old use of maxBufferredDocs > for controlling memory as a compromise. Now that setRAMBufferSizeMB is > available, applications can benefit from both. Do you mean to make maxBufferedDocs/maxBufferedDeleteTerms and ramBufferSize take effect at the same time? That is, a flush is triggered whenever one of the limits is reached? I think it's reasonable. If we make that change, we should also change a few default values to provide good out-of-box performance. Ning --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
