[ 
https://issues.apache.org/jira/browse/LUCENE-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550843
 ] 

Shai Erera commented on LUCENE-1088:
------------------------------------

If you're adding a wouldBeInserted method, I'd add a insertWithNoCheck that 
either calls put() (if there is room in the queue) or replaces the top() 
element, without re-evaluating the element (by calling lessThan). This will 
save unnecessary calls (the lessThan() method can be expensive). It should be 
documented in the method though that insertWithNoCheck assumes wouldBeInserted 
before.


> PriorityQueue 'wouldBeInserted' method
> --------------------------------------
>
>                 Key: LUCENE-1088
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1088
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: Other
>            Reporter: Peter Keegan
>            Assignee: Michael McCandless
>         Attachments: LUCENE-1088.patch
>
>
> This is a request for a new method in PriorityQueue
> public boolean wouldBeInserted(Object element)
> // returns true if doc would be inserted, without inserting 
> This would allow an application to prevent duplicate entries from being added 
> to the queue.
> Here is a reference to the discussion behind  this request:
> http://www.nabble.com/FieldSortedHitQueue-enhancement-to9733550.html#a9733550

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to