[ 
https://issues.apache.org/jira/browse/LUCENE-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550964
 ] 

Nadav Har'El commented on LUCENE-1088:
--------------------------------------

Michael, I agree - the most important fix was to make heap protected (and not 
private). After that, you're right, insertWithOverflow() and wouldBeInserted() 
could be implemented in a subclass in or even outside Lucene. Whether or not to 
include these new methods in the basic PriorityQueue should depend, I think, on 
how commonly needed these features will be for users, and whether we want to 
use them inside Lucene (like Shai's patches for TopDocCollector and other 
classes was doing)..

> PriorityQueue 'wouldBeInserted' method
> --------------------------------------
>
>                 Key: LUCENE-1088
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1088
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: Other
>            Reporter: Peter Keegan
>            Assignee: Michael McCandless
>         Attachments: LUCENE-1088.patch
>
>
> This is a request for a new method in PriorityQueue
> public boolean wouldBeInserted(Object element)
> // returns true if doc would be inserted, without inserting 
> This would allow an application to prevent duplicate entries from being added 
> to the queue.
> Here is a reference to the discussion behind  this request:
> http://www.nabble.com/FieldSortedHitQueue-enhancement-to9733550.html#a9733550

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to