OK, phew :)
I'll commit to trunk.
Michael, is it OK to commit to 2.3 too?
Mike
On Jan 11, 2008, at 3:27 PM, Steven A Rowe wrote:
Hi Mike,
I couldn't get the patch to apply (word wrapping/line endings/
whatever), so I just manually pasted in the added line after
deleting the corresponding removed line.
With the patched version, I got 0 failures out of 20 runs.
After I reverted back to the original version, I got 10 failures
out of 20 runs.
I'd say your patch wins!
Steve
On 01/11/2008 at 2:57 PM, Michael McCandless wrote:
Alas, so far I cannot repro this.
But I did see one off-by-one error in an assert the test. Steve,
could you try applying this patch and see if the failure still
happens? Thanks:
Index: src/test/org/apache/lucene/index/TestDeletionPolicy.java
=================================================================== -
--
src/test/org/apache/lucene/index/TestDeletionPolicy.java (revision
610858) +++ src/test/org/apache/lucene/index/TestDeletionPolicy.java
(working copy) @@ -229,7 +229,7 @@
"",
gen);
long modTime = dir.fileModified(fileName);
- assertTrue("commit point was older than " + SECONDS + "
seconds
but did not get deleted", lastDeleteTime - modTime <
(SECONDS*1000)); +
assertTrue("commit point was older than " + SECONDS + "
seconds ("
+ (lastDeleteTime - modTime) + " msec) but did not get deleted",
lastDeleteTime - modTime <= (SECONDS*1000));
} catch (IOException e) {
// OK
break;
Mike
Steven A Rowe wrote:
Hi Michael,
On 01/11/2008 at 3:34 AM, Michael Busch wrote:
I just uploaded Lucene 2.3 release candidate 2 to
http://people.apache.org/~buschmi/staging_area/lucene_2_3/rc2.
Please switch to RC2 and keep testing!
(The report below is not about binary release testing, but rather
running the tests from the source tree.)
Using the Sun JVM v1.4.2_16, on Windows XP SP2, I'm seeing
intermittent failures (roughly 50% failure rate) with
TestDeletionPolicy, both from the lucene_2_3 branch and from the
trunk (both at r611263).
PROMPT> ant clean test-core -Dtestcase=TestDeletionPolicy
common.test:
[mkdir] Created dir: c:\svn\lucene\java\branches\lucene_2_3
\build\test [junit] Testsuite:
org.apache.lucene.index.TestDeletionPolicy [junit] Tests run: 6,
Failures: 1, Errors: 0, Time elapsed: 4.015 sec [junit] [junit]
Testcase: testExpirationTimeDeletionPolicy
(org.apache.lucene.index.TestDeletionPolicy): FAILED [junit]
commit
point was older than 2.0 seconds but did
not get
deleted
[junit] junit.framework.AssertionFailedError: commit point was
older than 2.0 seconds but did not get deleted [junit] at
org.apache.lucene.index.TestDeletionPolicy.testExpirationTimeD
eletionP
olicy(TestDeletionPolicy.java:232)
[junit]
[junit]
[junit] Test org.apache.lucene.index.TestDeletionPolicy FAILED
However, using the Sun JVM v1.4.2_04 on Debian Etch (Linux kernel
2.6.20.7), the same test never fails.
Steve
--------------------------------------------------------------------
-
To unsubscribe, e-mail: [EMAIL PROTECTED] For
additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To
unsubscribe, e-mail: [EMAIL PROTECTED] For
additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
