Yonik Seeley wrote:

On Fri, Jul 11, 2008 at 3:27 PM, Ning Li <[EMAIL PROTECTED]> wrote:
We should also disallow concurrent addIndexes, right?

Hmmm, the current implementation looks like it won't currently won't
work correctly (docWriter.resumeAllThreads() being called while
another thread is calling addIndexes, etc).

Actually docWriter.pause/resumeAllThreads uses ref counting, so, these won't step on each other (ie threads are not actually resumed until all addIndexes calls have called resumeAllThreads).

But, the start/commit/rollbackTransaction calls will not be happy if more than one thread tries to open a transaction at once.

I'll fix it so a 2nd addIndexes call, while one is already running, will wait until the first one finishes before it then starts.

Mike

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to