Yonik Seeley wrote:

On Fri, Jul 11, 2008 at 2:38 PM, Michael McCandless
<[EMAIL PROTECTED]> wrote:

Hmm, I think we should.

What should it "mean" when you call commit(), while another thread is in the
middle of addIndexes?

Seems like either all or none of the segments in addIndexes should be committed.

We could 1) disallow it (throw an exception if you try), 2) allow it but block until addIndexes is done, 3) allow it but commit all changes up until
when addIndexes was first called ... anything else?

I think either 2 or 3 is reasonable, and we could avoid defining
which, as long as we do something reasonable.  If the application
really cares which is done, they should be synchronizing at a higher
level themselves.

I agree, the app should synchronize if it cares which of 2 or 3. For now I'll do 2...


I think there're similar problems with calling optimize() while addIndexes
is in progress... I think we should disallow that?

I don't think it should throw an exception... it seems like any kind
of constraint like that should be handled by IndexWriter.

Agreed, we shouldn't throw exceptions under any of these.

Mike

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to