Michael McCandless wrote:

Mark Miller wrote:

I tried a quick poor mans version using a MultiSearcher and wrapping the sub readers as searchers. Other than some AUTO sort field detection problems, all tests do appear to pass.

Excellent, that sounds like a tentatively positive result, though we do need to get to the bottom of those differences.

I'm going to dig in more tonight I hope. The main issue is that using SortType.AUTO blows up because the MultiSearcher code expects it already to have been resolved to a sort type, but my hack kept that from happening so it hits a switch statement for AUTO that throws an exception. That shouldn't be a problem. The other issue is a weird situation where it hits an INT switch statement when the sort type is Byte and throws a class cast exception. I didn't have time to look into anything, but I'm guessing its AUTO related as well. Both probably non issues once I get time to do more.


The new sort stuff for MultiSearcher may be a tiny bit off...sort tests fail, though are only slightly off, with that patch. Havn't looked further yet - just hacked it up real quick. Seems to work, but needs work.

Which new sort stuff are you referring to?  Is it LUCENE-1471?

Yes. First thing I did was try and patch this in, but the sort tests failed. It would be the right order, but like the two center docs would be reversed or something. No time to dig in, so I just switch to the trunk MultiSearcher and all tests passed except for the two with the above issues.

- Mark


Mike

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to