[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655709#action_12655709
]
Mark Miller commented on LUCENE-1483:
-------------------------------------
bq. Looks good! Do we really need IndexReader.supportsSequentialReaders?
Because the default impl (return length 1 array of itself) seems sufficient?
Let me investigate. If you try using the default impl, and you change the
parralellreaderreopen test to use getSequintialReaders rather than
getSubReaders, the test will throw a stack trace overflow on checking if the
reader is closed. I put the illegal in there to make sure I wasnt calling it,
because upon switching to getSubReaders, problem goes away. Seemed fair enough,
but I'll I guess have to understand what was going on to really respond.
bq. It would be nice to somehow deprecate "supportsDocBase" so that all outside
HitCollectors would need to support it on upgrading to 3.0, but, I'm not sure
how to cleanly do that. (Ie I'd rather not have that method continue to exist
in 3.0).
+1. I dont see what we can do but release it deprecated with a note explaining.
Fair enough for 3.0 I think.
bq. It's a delightfully small patch now!
Yeah, this one had the great feeling of the multiterm patch - rolled right up
into something nice. Goto love the Lucene API, flaws or not.
> Change IndexSearcher to use MultiSearcher semantics for multiple subreaders
> ---------------------------------------------------------------------------
>
> Key: LUCENE-1483
> URL: https://issues.apache.org/jira/browse/LUCENE-1483
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 2.9
> Reporter: Mark Miller
> Priority: Minor
> Attachments: LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch,
> LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch,
> LUCENE-1483.patch
>
>
> FieldCache and Filters are forced down to a single segment reader, allowing
> for individual segment reloading on reopen.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
