[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655716#action_12655716
]
Mark Miller commented on LUCENE-1483:
-------------------------------------
bq. But you shouldn't change that test (it should continue to call
ParalellReader.getSubReaders).
Right, I was coming at it from the wrong angle. I had refactored in the change
with eclipse, and seeing that ParalellReader.getSuquentialReaders could cause a
statckoverflow, thats why i put in the isSequentialSuported check. Guess its
not a concern though. I didn't take much time to understand it.
bq. The problem is this doesn't create a the right sequence. Ie, if we mark
supportsDocBase as deprecated, then some ExternalHitCollector won't see the
deprecation warning (they have not overridden supportsDocBase), and so then we
can't remove it in 3.0 since their code will then silently break. I think the
only thing to do would be deprecate collect() in favor of another method. Or,
deprecate HitCollector entirely in favor of new class DocBaseHitCollector
(don't like that name). Sigh...
This depends right? Don't we have a lot of latitude with 3.0? I would think we
could require that you read some upgrade notes on changes...3.0 is our hope to
change some things we couldn't normally get away with I thought :) I agree we
should be friendly, like 1 to 2, but its tempting to use 3.0 to do some things
more cleanly rather than less.
> Change IndexSearcher to use MultiSearcher semantics for multiple subreaders
> ---------------------------------------------------------------------------
>
> Key: LUCENE-1483
> URL: https://issues.apache.org/jira/browse/LUCENE-1483
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 2.9
> Reporter: Mark Miller
> Priority: Minor
> Attachments: LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch,
> LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch,
> LUCENE-1483.patch, LUCENE-1483.patch
>
>
> FieldCache and Filters are forced down to a single segment reader, allowing
> for individual segment reloading on reopen.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
