> Earwin Burrfoot wrote: >> >> Benefits are numerous. We get rid of alien code like: >> +++ src/java/org/apache/lucene/index/SegmentReader.java (working copy) >> @@ -83,6 +86,8 @@ >> + protected ValueSource valueSource; >> + >> @@ -555,6 +560,8 @@ >> + >> + valueSource = new CachingValueSource(this, new >> UninversionValueSource(this)); >> > > No need to rid Lucene of code thats not there :) Irregardless of the merits > of IndexReader plugins, no need to design an API to solve experimental code > in a rough, early patch for a given issue;) > > Design of the new FieldCache is happening at 831, and no comments are > ignored in that discussion. We are not committing something tonight that > will not meet your needs. No worries. Shoddy work does not appear to slip > past McCandless when its time to commit :) (and it may be a long time yet > for 831)
I probably went a bit overboard with dramatism. :) But it doesn't make the proposed API any less useful. -- Kirill Zakharenko/Кирилл Захаренко (ear...@gmail.com) Home / Mobile: +7 (495) 683-567-4 / +7 (903) 5-888-423 ICQ: 104465785 --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
