[ https://issues.apache.org/jira/browse/LUCENE-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless reopened LUCENE-1529: ---------------------------------------- I think something is wrong with this fix. Over in LUCENE-1593 we hit a case where (I think) the test should have failed, because we changed a method from returning void to returning something else. EG if you change IndexWriter.addDocument to (say) return int instead of void, then I think ant test-tag should fail, but it doesn't. > back-compat tests ("ant test-tag") should test JAR drop-in-ability > ------------------------------------------------------------------ > > Key: LUCENE-1529 > URL: https://issues.apache.org/jira/browse/LUCENE-1529 > Project: Lucene - Java > Issue Type: New Feature > Components: Build > Affects Versions: 2.9 > Reporter: Michael McCandless > Assignee: Michael Busch > Priority: Minor > Fix For: 2.9 > > Attachments: lucene-1529.patch > > > We now test back-compat with "ant test-tag", which is very useful for > catching breaks in back compat before committing. > However, that currently checks out "src/test" sources and then > compiles them against the trunk JAR, and runs the tests. Whereas our > back compat policy: > http://wiki.apache.org/lucene-java/BackwardsCompatibility > states that no recompilation is required on upgrading to a new JAR. > Ie you should be able to drop in the new JAR in place of your old one > and things should work fine. > So... we should fix "ant test-tag" to: > * Do full checkout of core sources & tests from the back-compat-tag > * Compile the JAR from the back-compat sources > * Compile the tests against that back-compat JAR > * Swap in the trunk JAR > * Run the tests -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org