[ 
https://issues.apache.org/jira/browse/LUCENE-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699030#action_12699030
 ] 

Shai Erera commented on LUCENE-1529:
------------------------------------

Mike - you 'almost' fixed it :)

I "ant clean test-tag" and still sees failures. So I checked and 
common-build.xml still references lucene_2_4_back_compat_tests_20090320. I do 
see your changes on the lucene_2_4_back_compat_tests branch, but you didn't tag 
those changes?

We can either move to checkout this code from the branch (thus preventing such 
issues in the future), in build.xml target=download-tag, or tag the changes and 
update common-build.xml.

> back-compat tests ("ant test-tag") should test JAR drop-in-ability
> ------------------------------------------------------------------
>
>                 Key: LUCENE-1529
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1529
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: Build
>    Affects Versions: 2.9
>            Reporter: Michael McCandless
>            Assignee: Michael Busch
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: lucene-1529.patch
>
>
> We now test back-compat with "ant test-tag", which is very useful for
> catching breaks in back compat before committing.
> However, that currently checks out "src/test" sources and then
> compiles them against the trunk JAR, and runs the tests.  Whereas our
> back compat policy:
>   http://wiki.apache.org/lucene-java/BackwardsCompatibility
> states that no recompilation is required on upgrading to a new JAR.
> Ie you should be able to drop in the new JAR in place of your old one
> and things should work fine.
> So... we should fix "ant test-tag" to:
>   * Do full checkout of core sources & tests from the back-compat-tag
>   * Compile the JAR from the back-compat sources
>   * Compile the tests against that back-compat JAR
>   * Swap in the trunk JAR
>   * Run the tests

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to