I believe we debated allowing the DISI to return any docID less than its first real docID, not only -1, as you've done here, but I think Shai found something wrong with that IIRC... but I can't find this discussion. Shai do you remember / can you find this past discussion / am I just hallucinating?
Mike On Wed, Jul 15, 2009 at 6:09 PM, Uwe Schindler<u...@thetaphi.de> wrote: >> > This Impl should do it. The problem is, if (last==Integer.MAX_VALUE), >> then >> > it would break because of overflow. >> >> That part is OK... I'm more talking about the Javadoc for docID() >> which states that it returns >> * <li>-1 or {...@link #NO_MORE_DOCS} if {...@link #nextDoc()} or >> * {...@link #advance(int)} were not called yet. >> >> This implementation does not conform to that. > > Ah, I understand. > > I was also thinking about that, when I reimplemented FieldCacheRangeFilter's > DocIdSet implementation. But then I fixed it, to conform to this. > > I am not sure if this is really a problem. > > Uwe > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org > For additional commands, e-mail: java-dev-h...@lucene.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org