[
https://issues.apache.org/jira/browse/LUCENE-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737548#action_12737548
]
Ryan McKinley commented on LUCENE-1504:
---------------------------------------
Don't try to read much into anything I did here (the patch here is from
patrick)... my understanding of the reason for BitSet vs DocIdSet is slim. I
just noted that SerialChainFilter relies on a deprecated API.
----
If it is possible to merge this with the exiting FilteredDocIdSet, that seems
like the best approach.
----
Also, the spatial contrib will be marked "experimental" for 2.9, so the
back-compatibility contract should not be as strict . If this improvement can
not get the attention it deserves before 2.9 release, the SerialChainFilter
could still be removed/moved/modified at a later release.
> SerialChainFilter should use DocSet API rather then deprecated BitSet API
> -------------------------------------------------------------------------
>
> Key: LUCENE-1504
> URL: https://issues.apache.org/jira/browse/LUCENE-1504
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/spatial
> Reporter: Ryan McKinley
> Assignee: Uwe Schindler
> Fix For: 2.9
>
> Attachments: LUCENE-1504.patch, LUCENE-1504.patch
>
>
> From erik's comments in LUCENE-1387
> * Maybe the Filter's should be using the DocIdSet API rather than the
> BitSet deprecated stuff? We can refactor that after being committed I
> supposed, but not something we want to leave like that.
> We should also look at moving SerialChainFilter out of the spatial contrib
> since it is more generally useful then just spatial search.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
