[ 
https://issues.apache.org/jira/browse/LUCENE-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737578#action_12737578
 ] 

Michael McCandless commented on LUCENE-1504:
--------------------------------------------

bq. So you mean we should simply kick this new class and use whats already in 
Lucene?

Right, that's what I did on first cut patch above: I use FilteredDocIdSet to 
efficiently AND the approx distance filter w/ the precise filter, and then 
ChainedFilter to combine an incoming Query-as-filter with the approx+precise 
distance filter.

We really need a random-access Filter API (LUCENE-1536); if we had that then we 
could have better support for efficiently ANDing filters.  I suppose 
FilteredDocIdSet is in fact a start at a random access Filter API: it exposes 
only the method boolean match(int doc).

> SerialChainFilter should use DocSet API rather then deprecated BitSet API
> -------------------------------------------------------------------------
>
>                 Key: LUCENE-1504
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1504
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/spatial
>            Reporter: Ryan McKinley
>            Assignee: Uwe Schindler
>             Fix For: 2.9
>
>         Attachments: LUCENE-1504.patch, LUCENE-1504.patch, LUCENE-1504.patch
>
>
> From erik's comments in LUCENE-1387
>     * Maybe the Filter's should be using the DocIdSet API rather than the 
> BitSet deprecated stuff? We can refactor that after being committed I 
> supposed, but not something we want to leave like that.
> We should also look at moving SerialChainFilter out of the spatial contrib 
> since it is more generally useful then just spatial search.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to