[ https://issues.apache.org/jira/browse/LUCENE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756275#action_12756275 ]
Uwe Schindler commented on LUCENE-1911: --------------------------------------- bq. Doesn't really matter too much - Solr doesn't use CachingWrapperFilter at all. But I'll handle any instances on upgrade of the Lucene libs Thanks! bq. then a couple that use an underlying OpenBitSet These are easy, because OpenBitSet has isCacheable()==true -> nothing to do bq. but as Yonik says - it doesn't appear it would end up being an issue - CachingWrapperFilter isn't likely ever going to be used with them - nice to have them correct anyhow though. Correct. And nothing breaks if you have a cacheable DocIdSet not marked as such. It will simply be copied to an OpenBitSet (with some perf and memory cost on the first call to CachingWrapperFilter.getDocIdSet()). > When using QueryWrapperFilter with CachingWrapperFilter, QueryWrapperFilter > returns a DocIdSet that creates a Scorer, which gets cached rather than a bit > set > ------------------------------------------------------------------------------------------------------------------------------------------------------------- > > Key: LUCENE-1911 > URL: https://issues.apache.org/jira/browse/LUCENE-1911 > Project: Lucene - Java > Issue Type: Bug > Reporter: Mark Miller > Assignee: Uwe Schindler > Fix For: 2.9 > > Attachments: LUCENE-1911.patch, LUCENE-1911.patch, LUCENE-1911.patch, > LUCENE-1911.patch > > > there is a large performance cost to this. > The old impl for this type of thing, QueryFilter, recommends : > @deprecated use a CachingWrapperFilter with QueryWrapperFilter > The deprecated QueryFilter itself also suffers from the problem because its > now implemented using a CachingWrapperFilter and QueryWrapperFilter. > see > http://search.lucidimagination.com/search/document/7f54715f14b8b7a/lucene_2_9_0rc4_slower_than_2_4_1 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org