[ 
https://issues.apache.org/jira/browse/LUCENE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Uwe Schindler updated LUCENE-1911:
----------------------------------

    Attachment: LUCENE-1911.patch

Thanks Thomas!

Attached is a improved patch, that uses OpenBitSetDISI, a subclass of 
OpenBitSet, which does the copying of the iterator to the bit set by itsself. 
Why duplicate the code?

It also handles the null return value of iterator(), which is allowed. It 
caches an EMPTY_DOCIDSET in this case.

I will commit soon!

> When using QueryWrapperFilter with CachingWrapperFilter, QueryWrapperFilter 
> returns a DocIdSet that creates a Scorer, which gets cached rather than a bit 
> set
> -------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1911
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1911
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Mark Miller
>            Assignee: Uwe Schindler
>             Fix For: 2.9
>
>         Attachments: LUCENE-1911.patch, LUCENE-1911.patch, LUCENE-1911.patch, 
> LUCENE-1911.patch, LUCENE-1911.patch, lucene_29_newapi_patched.png
>
>
> there is a large performance cost to this.
> The old impl for this type of thing, QueryFilter, recommends :
> @deprecated use a CachingWrapperFilter with QueryWrapperFilter
> The deprecated QueryFilter itself also suffers from the problem because its 
> now implemented using a CachingWrapperFilter and QueryWrapperFilter.
> see 
> http://search.lucidimagination.com/search/document/7f54715f14b8b7a/lucene_2_9_0rc4_slower_than_2_4_1

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to