[
https://issues.apache.org/jira/browse/LUCENE-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12757092#action_12757092
]
Uwe Schindler commented on LUCENE-1919:
---------------------------------------
I would suggest to create a new RC because of this issue. The TokenStream BW
stuff is very tricky and is not limited to only one TokenStream. When fixing
thigs here, you must always also look into issues that could arise by mixing
old/new API. The current issue is a typical example for that. Your brain is
always "fuming", when you think about what happens if TF1 calls TF2 using old
API, but TF2 is new API and calls TF3 using new API. TF3 itsself is again very
old API without reuse and so on.
But this one is new, a reusable TF is calling another TS mixing the APIs, but
the changes also affect the other variants. So testing, testing, testing and
take a cold shower when your brain starts getting hot :-)
I will commit the current patch later in the afternoon, when you are awake at
the west coast.
> Analysis back compat break
> --------------------------
>
> Key: LUCENE-1919
> URL: https://issues.apache.org/jira/browse/LUCENE-1919
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Yonik Seeley
> Assignee: Uwe Schindler
> Fix For: 2.9
>
> Attachments: LUCENE-1919.patch, LUCENE-1919.patch, LUCENE-1919.patch,
> LUCENE-1919.patch, LUCENE-1919.patch
>
>
> Old and new style token streams don't mix well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
