[ https://issues.apache.org/jira/browse/LUCENE-1937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763334#action_12763334 ]
Adriano Crestani commented on LUCENE-1937: ------------------------------------------ Hi Luis, {quote} Wouldn't it be better for the pipeline to implement the "List" interface. What do you think? {quote} Yes, it's one of the valid approaches, I just didn't want to tie it initially to an interface. I will code that later and provide a new patch. > Add more methods to manipulate QueryNodeProcessorPipeline elements > ------------------------------------------------------------------ > > Key: LUCENE-1937 > URL: https://issues.apache.org/jira/browse/LUCENE-1937 > Project: Lucene - Java > Issue Type: Improvement > Components: contrib/* > Affects Versions: 2.9 > Reporter: Adriano Crestani > Assignee: Adriano Crestani > Priority: Minor > Fix For: 3.1 > > Attachments: LUCENE-1937.patch > > > QueryNodeProcessorPipeline allows the user to define a list of processors to > process a query tree. However, it's not very flexible when the user wants to > extend/modify an already created pipeline, because it only provides an add > method, which only allows the user to append a new processor to the pipeline. > So, I propose to add new methods to manipulate the processor in a pipeline. I > think the methods should not consider an index position when modifying the > pipeline, hence the index position in a pipeline does not mean anything, a > processor has a meaning when it's after or before another processor. > Therefore, I suggest the methods should always consider another processor > when inserting/modifying the pipeline. For example, insertAfter(processor, > newProcessor), which will insert the "newProcessor" after the "processor". -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org