Didn't start yet, and I just committed this! Thanks Robert.
Mike
On Thu, Oct 29, 2009 at 12:03 PM, Robert Muir <rcm...@gmail.com> wrote:
> if you havent already started, i found a minor problem in the smartcn public
> javadocs while updating it to generics. here is a patch for 29 branch
>
> Index:
> contrib/analyzers/smartcn/src/java/org/apache/lucene/analysis/cn/smart/hhmm/HHMMSegmenter.java
> ===================================================================
> ---
> contrib/analyzers/smartcn/src/java/org/apache/lucene/analysis/cn/smart/hhmm/HHMMSegmenter.java
> (revision 831005)
> +++
> contrib/analyzers/smartcn/src/java/org/apache/lucene/analysis/cn/smart/hhmm/HHMMSegmenter.java
> (working copy)
> @@ -22,7 +22,7 @@
> import org.apache.lucene.analysis.cn.smart.CharType;
> import org.apache.lucene.analysis.cn.smart.Utility;
> import org.apache.lucene.analysis.cn.smart.WordType;
> -import org.apache.lucene.analysis.cn.smart.hhmm.PathNode;//javadoc @link
> +import org.apache.lucene.analysis.cn.smart.hhmm.SegToken;//javadoc @link
>
> /**
> * Finds the optimal segmentation of a sentence into Chinese words
> @@ -192,7 +192,7 @@
> }
>
> /**
> - * Return a list of {...@link PathNode} representing the best segmentation
> of a sentence
> + * Return a list of {...@link SegToken} representing the best segmentation
> of a sentence
> * @param sentence input sentence
> * @return best segmentation as a {...@link List}
> */
>
>
> On Thu, Oct 29, 2009 at 10:57 AM, Michael McCandless
> <luc...@mikemccandless.com> wrote:
>>
>> So the 3 issues are now back-ported to 2.9.x branch. Any other issues
>> we want to back port? If nobody answers in a few hours I'll spin a
>> new RC...
>>
>> Mike
>>
>> On Thu, Oct 29, 2009 at 6:27 AM, Michael McCandless
>> <luc...@mikemccandless.com> wrote:
>> > OK I'll spin a new RC.
>> >
>> > I'll also backport the thread-safety fix to contrib/benchmark
>> > (LUCENE-1994).
>> >
>> > Mike
>> >
>> > On Thu, Oct 29, 2009 at 6:13 AM, Uwe Schindler <u...@thetaphi.de> wrote:
>> >> Robert found another bug in 2.9. I resolved one yesterday and reopened
>> >> LUCENE-2002.
>> >>
>> >> So I changed my mind: -1 :(
>> >>
>> >> -----
>> >> Uwe Schindler
>> >> H.-H.-Meier-Allee 63, D-28213 Bremen
>> >> http://www.thetaphi.de
>> >> eMail: u...@thetaphi.de
>> >>
>> >>
>> >>> -----Original Message-----
>> >>> From: Robert Muir [mailto:rcm...@gmail.com]
>> >>> Sent: Wednesday, October 28, 2009 1:05 PM
>> >>> To: java-dev@lucene.apache.org
>> >>> Cc: gene...@lucene.apache.org
>> >>> Subject: Re: [VOTE] Release Apache Lucene Java 2.9.1, take 2
>> >>>
>> >>> +1
>> >>>
>> >>> On Mon, Oct 26, 2009 at 2:43 PM, Michael McCandless <
>> >>> luc...@mikemccandless.com> wrote:
>> >>>
>> >>> > OK, I've built new release artifacts (incorporating Uwes feedback)
>> >>> > from svn rev 829889 (on the 2.9 branch), here:
>> >>> >
>> >>> > http://people.apache.org/~mikemccand/staging-
>> >>> area/rc2_lucene2.9.1/<http://people.apache.org/%7Emikemccand/staging-
>> >>> area/rc2_lucene2.9.1/>
>> >>> >
>> >>> > Changes are here:
>> >>> >
>> >>> > http://people.apache.org/~mikemccand/staging-
>> >>>
>> >>> area/rc2_lucene2.9.1changes/<http://people.apache.org/%7Emikemccand/stagin
>> >>> g-area/rc2_lucene2.9.1changes/>
>> >>> >
>> >>> > Please vote to officially release these artifacts as Apache Lucene
>> >>> > Java 2.9.1.
>> >>> >
>> >>> > Mike
>> >>> >
>> >>> >
>> >>> > ---------------------------------------------------------------------
>> >>> > To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
>> >>> > For additional commands, e-mail: java-dev-h...@lucene.apache.org
>> >>> >
>> >>> >
>> >>>
>> >>>
>> >>> --
>> >>> Robert Muir
>> >>> rcm...@gmail.com
>> >>
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
>> >> For additional commands, e-mail: java-dev-h...@lucene.apache.org
>> >>
>> >>
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
>> For additional commands, e-mail: java-dev-h...@lucene.apache.org
>>
>
>
>
> --
> Robert Muir
> rcm...@gmail.com
>
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
