[ 
https://issues.apache.org/jira/browse/LUCENE-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777445#action_12777445
 ] 

Simon Willnauer commented on LUCENE-2051:
-----------------------------------------

This would also include deprecating some of the constructors. I will attach a 
patch which adds / deprecates ctors for all analyzers having those setters too.

simon

> Contrib Analyzer Setters should be deprecated and replace with ctor arguments
> -----------------------------------------------------------------------------
>
>                 Key: LUCENE-2051
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2051
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/analyzers
>    Affects Versions: 2.9.1
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>            Priority: Minor
>             Fix For: 3.0
>
>
> Some analyzers in contrib provide setters for stopword / stem exclusion sets 
> / hashtables etc. Those setters should be deprecated as they yield unexpected 
> behaviour. The way they work is they set the reusable token stream instance 
> to null in a thread local cache which only affects the tokenstream in the 
> current thread. Analyzers itself should be immutable except of the 
> threadlocal. 
> will attach a patch soon.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to