[
https://issues.apache.org/jira/browse/LUCENE-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778163#action_12778163
]
Robert Muir commented on LUCENE-2051:
-------------------------------------
simon, should we expose the getDefaultStopSet() as public yet, if you are
planning on refactoring this stopword stuff in 3.1 anyway? (would you have to
then deprecate this in 3.1?)
also, I'm not sure i like the copy() method in CharArraySet, i think it should
return a real copy even if it is an EMPTY_SET, and if you give it a
CharArraySet it should call .clone() ?
other things are minor, in Czech i think there is a spurious import added
(javax.print.DocFlavor.CHAR_ARRAY), etc.
nothing to do with your issue, but maybe while we are here cleaning up these
ctors we should fix the fact that a lot of these never call super() ?
> Contrib Analyzer Setters should be deprecated and replace with ctor arguments
> -----------------------------------------------------------------------------
>
> Key: LUCENE-2051
> URL: https://issues.apache.org/jira/browse/LUCENE-2051
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/analyzers
> Affects Versions: 2.9.1
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Priority: Minor
> Fix For: 3.0
>
> Attachments: LUCENE-2051.patch
>
>
> Some analyzers in contrib provide setters for stopword / stem exclusion sets
> / hashtables etc. Those setters should be deprecated as they yield unexpected
> behaviour. The way they work is they set the reusable token stream instance
> to null in a thread local cache which only affects the tokenstream in the
> current thread. Analyzers itself should be immutable except of the
> threadlocal.
> will attach a patch soon.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
