[ 
https://issues.apache.org/jira/browse/LUCENE-2068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779834#action_12779834
 ] 

Simon Willnauer commented on LUCENE-2068:
-----------------------------------------

bq: edit: sorry simon, mime-type/charset issues on my side, x-diff versus 
x-patch thing 

:) happens :)

bq. If it's really that broken for supplemental chars, we don't have to support 
back compat, right? 

+1 This code is completely broken without the patch, I would agree we do not 
need it in this case.

simon

> fix reverseStringFilter for unicode 4.0
> ---------------------------------------
>
>                 Key: LUCENE-2068
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2068
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/analyzers
>            Reporter: Robert Muir
>            Assignee: Simon Willnauer
>            Priority: Minor
>             Fix For: 3.1
>
>         Attachments: LUCENE-2068.patch, LUCENE-2068.patch, LUCENE_2068.patch, 
> LUCENE_2068.patch
>
>
> ReverseStringFilter is not aware of supplementary characters: when it 
> reverses it will create unpaired surrogates, which will be replaced by U+FFFD 
> by the indexer (but not at query time).
> The wrong words will conflate to each other, and the right words won't match, 
> basically the whole thing falls apart.
> This patch implements in-place reverse with the algorithm from apache harmony 
> AbstractStringBuilder.reverse0()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to