[
https://issues.apache.org/jira/browse/LUCENE-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-2088:
----------------------------------
Attachment: LUCENE-2088-test.patch
This patch shows how you can break.
As Shai said, the problem is not only that it may have no effect, it completely
breaks the behaviour of AttributeSource when you do this. Because of that the
extra check is needed.
> AttributeSource.addAttribute should only accept interfaces, the missing test
> leads to problems with Token.TOKEN_ATTRIBUTE_FACTORY
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-2088
> URL: https://issues.apache.org/jira/browse/LUCENE-2088
> Project: Lucene - Java
> Issue Type: Bug
> Affects Versions: 2.9, 2.9.1, 3.0
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Priority: Blocker
> Fix For: 3.0
>
> Attachments: LUCENE-2088-test.patch, LUCENE-2088.patch
>
>
> This is a blocker, because you can call addAttribute(Token.class) without
> getting an error message.
> I will commit the fix and restart the vote for 3.0. This also applies to 2.9,
> but there is no Token Attribute Factory. But I will merge to 2.9, too, if a
> 2.9.2 comes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
