[
https://issues.apache.org/jira/browse/LUCENE-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781129#action_12781129
]
Uwe Schindler commented on LUCENE-2088:
---------------------------------------
Thinking about it more and reading
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6461827 maybe we should
remove it again. But addAttributeImpl already does a lot of isAssignableFrom
checks (but cached) so maybe we should remove it for 3.0/3.1. In 2.9 it must
stay alive.
What do others think?
> AttributeSource.addAttribute should only accept interfaces, the missing test
> leads to problems with Token.TOKEN_ATTRIBUTE_FACTORY
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-2088
> URL: https://issues.apache.org/jira/browse/LUCENE-2088
> Project: Lucene - Java
> Issue Type: Bug
> Affects Versions: 2.9, 2.9.1, 3.0
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Priority: Blocker
> Fix For: 3.0
>
> Attachments: LUCENE-2088-test.patch, LUCENE-2088.patch
>
>
> This is a blocker, because you can call addAttribute(Token.class) without
> getting an error message.
> I will commit the fix and restart the vote for 3.0. This also applies to 2.9,
> but there is no Token Attribute Factory. But I will merge to 2.9, too, if a
> 2.9.2 comes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
