[ 
https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786749#action_12786749
 ] 

Robert Muir commented on LUCENE-2122:
-------------------------------------

Hi Erick, I am a little nervous about the change to 
LocalizedTestCase.tearDown() here.

I think we must restore the users default Locale, since its a JRE-system wide 
global thing and we are changing it on the fly here.

this was stashed away here before:
{code}
 /**
   * Before changing the default Locale, save the default Locale here so that it
   * can be restored.
   */
  private final Locale defaultLocale = Locale.getDefault();
{code}

and restored in tearDown()... otherwise strange things could happen, such as 
your IDE could go bonkers after running the tests! (but maybe I am missing 
something)

> Use JUnit4 capabilites for more thorough Locale testing for classes deriving 
> from LocalizedTestCase
> ---------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-2122
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2122
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Other
>    Affects Versions: 3.1
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Minor
>             Fix For: 3.1
>
>         Attachments: LUCENE-2122.patch
>
>
> Use the @Parameterized capabilities of Junit4 to allow more extensive testing 
> of Locales.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to