Hmmm, you're probably right. There's no earthly reason for a test writer to create an instance of LocalizedTestCase, it has no use except as a superclass by its nature even though it has no abstract methods. So making it abstract will server to flag that fact to anyone who tries to instantiate it.
I'll change this too, hold off on applying this patch, I'll wait for a bit to gather more comments and put them all together in an r3 version. Erick On Sun, Dec 6, 2009 at 9:02 PM, Robert Muir (JIRA) <j...@apache.org> wrote: > > [ > https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786757#action_12786757] > > Robert Muir commented on LUCENE-2122: > ------------------------------------- > > Erick do you think LocalizedTestCase should be abstract? > > > Use JUnit4 capabilites for more thorough Locale testing for classes > deriving from LocalizedTestCase > > > --------------------------------------------------------------------------------------------------- > > > > Key: LUCENE-2122 > > URL: https://issues.apache.org/jira/browse/LUCENE-2122 > > Project: Lucene - Java > > Issue Type: Improvement > > Components: Other > > Affects Versions: 3.1 > > Reporter: Erick Erickson > > Assignee: Erick Erickson > > Priority: Minor > > Fix For: 3.1 > > > > Attachments: LUCENE-2122-r2.patch, LUCENE-2122.patch > > > > > > Use the @Parameterized capabilities of Junit4 to allow more extensive > testing of Locales. > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org > For additional commands, e-mail: java-dev-h...@lucene.apache.org > >
