[ 
https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788455#action_12788455
 ] 

Robert Muir commented on LUCENE-2122:
-------------------------------------

thanks Erick, i will play around with the patch some, generally just 
double-check the locale stuff is doing what we want, looks like it will.

i havent tested yet, but looking at the code i have a few questions (i can try 
to add these to the patch just curious what you think):
1. if a test fails under some locale, say th_TH, will junit 4 attempt to print 
this parameter out in some way so I know that it failed? If not do you know of 
a hack?
2. i am thinking about reordering the locale array so that it tests the default 
one first. if you are trying to do some test-driven dev it might be strange if 
the test fails under a different locale first. I think this one is obvious, I 
will play with it to see how it behaves now.


> Use JUnit4 capabilites for more thorough Locale testing for classes deriving 
> from LocalizedTestCase
> ---------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-2122
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2122
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Other
>    Affects Versions: 3.1
>            Reporter: Erick Erickson
>            Assignee: Robert Muir
>            Priority: Minor
>             Fix For: 3.1
>
>         Attachments: LUCENE-2122-r2.patch, LUCENE-2122-r3.patch, 
> LUCENE-2122-r4.patch, LUCENE-2122.patch
>
>
> Use the @Parameterized capabilities of Junit4 to allow more extensive testing 
> of Locales.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to