<<<its possible the problems are not reproduceable because they are a crazy problem with these tests.>>>
Agree absolutely. I was just making sure we considered the *possibility* that the paramaterized version was showing an underlying Lucene problem rather than assuming the fault was with Junit4. Having spent a way too much of my programming life being absolutely sure I knew what part of the system was causing the failure only to find that the problem was waaay over *there* instead, I'm kinda sensitive that way <G>... I'll eagerly await your results... Erick On Sun, Dec 13, 2009 at 5:24 PM, Robert Muir <rcm...@gmail.com> wrote: > Erick it might be a gremlin on my computer or my brain... > also i think i was inadvertently using different JVM's for running ant test > (sometimes java 5/64bit sometimes 6/32bit). this is because i was doing > something with forrest and changed my JAVA_HOME in one shell window. > > so i'm going to run 100 ant clean tests with each JVM, logging to a file. > if these work reliably then I think I will conclude I was doing something > stupid before... (like forgot to ant clean or something like that) > > this computer is windows, so you are right it might have different locales > than your mac. > > however, i think we should consider your last comment: its possible the > problems are not reproduceable because they are a crazy problem with these > tests. > for example, i think we should be extra cautious and call Calendar.clear() > on all our calendars before changing time values and then asserting expected > results. > I don't see any obvious problem though, just thinking if something based on > the 'current time' was affecting the tests, then this might make it hard to > reproduce. > > > On Sat, Dec 12, 2009 at 9:26 PM, Erick Erickson > <erickerick...@gmail.com>wrote: > >> Hmmmm, you can't get either patch to work reliably. >> On the other hand, I can't get either patch to fail. >> I ran the whole ant clean test thing half a dozen times. >> I'll make a script to loop all night tonight and we'll see. >> I also ran just the TestQueryParser around 700 times >> from Ant via a shell script. No problems. No problems >> in IntelliJ. Siiggghhh. >> >> Anybody else want to try applying either patch and see >> what happens? I'd hate to lose the capabilities of the >> Parameterized tests because of a gremlin that only exists >> on Robert's machine. I'd also hate to introduce "cool new >> capabilities" that started training us to ignore test failures. >> That's bad. Very bad. >> >> Robert: What kind of machine are you running on? I'm running >> on a Macbook Pro... >> >> As it stands, I'm not sure whether parameterized tests are >> the issue or whether the issue is Locale testing. Or whether >> Robert has some peculiar setup. Or, for that matter, whether >> I have some peculiar setup that makes it work by hiding an >> instability. It sure would be nice to figure out where the >> fragility is before relying on Parameterized tests... >> >> Robert: >> If you have the patience, could you try your patch out and >> capture the failure? I'm especially curious if your patch >> fails on the same language every time. Who knows? On >> your machine, this *could* be hitting an edge case, that's >> actually a flaw in the code somewhere rather than an artifact >> of the test framework. I don't even know if my machine >> is using all of the same Locale's as yours.... >> >> I'd have at figuring out what was going on, but I can't make >> it fail. "It works on my machine" doesn't leave me very many >> directions forward.... >> >> But I'm sooooo glad that Robert is finding this nonsense >> *before* we get too much farther down this road rather than >> after.... >> >> I'll poke around on the internet and see if there's anything there >> that I can see. >> >> Erick >> >> >> On Sat, Dec 12, 2009 at 8:55 AM, Robert Muir (JIRA) <j...@apache.org>wrote: >> >>> >>> [ >>> https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel] >>> >>> Robert Muir updated LUCENE-2122: >>> -------------------------------- >>> >>> Assignee: (was: Robert Muir) >>> >>> i am unassigning in case someone else can figure this one out, at my wits >>> end here :) >>> perhaps its just something wierd about my environment or something >>> >>> > Use JUnit4 capabilites for more thorough Locale testing for classes >>> deriving from LocalizedTestCase >>> > >>> --------------------------------------------------------------------------------------------------- >>> > >>> > Key: LUCENE-2122 >>> > URL: https://issues.apache.org/jira/browse/LUCENE-2122 >>> > Project: Lucene - Java >>> > Issue Type: Improvement >>> > Components: Other >>> > Affects Versions: 3.1 >>> > Reporter: Erick Erickson >>> > Priority: Minor >>> > Fix For: 3.1 >>> > >>> > Attachments: LUCENE-2122-r2.patch, LUCENE-2122-r3.patch, >>> LUCENE-2122-r4.patch, LUCENE-2122.patch, LUCENE-2122.patch >>> > >>> > >>> > Use the @Parameterized capabilities of Junit4 to allow more extensive >>> testing of Locales. >>> >>> -- >>> This message is automatically generated by JIRA. >>> - >>> You can reply to this email to add a comment to the issue online. >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org >>> For additional commands, e-mail: java-dev-h...@lucene.apache.org >>> >>> >> > > > -- > Robert Muir > rcm...@gmail.com >
