[ 
https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794629#action_12794629
 ] 

Robert Muir commented on LUCENE-2122:
-------------------------------------

Erick the test problems havent gone away (see latest hudson  failure), but as 
you can see they appear to be unrelated to your patch, but existing problems.

I am glad Uwe and Hudson are now seeing the failures I saw, but unfortunately I 
am unable to reproduce this problem. I think it is very wierd that it only 
recently has started happening and the Junit 4 jar file is looking very  
suspicious to me :)

The next step is to force another test failure (with existing trunk code), 
except with an additional assertion in TestQueryParser.getParser(), that 
asserts that the created queryparser has the same Locale as 
LocalizedTestcase.locale

If this assertion is not triggered, and a failure happens anyway, then there is 
no problem with LocalizedTestCase and we should commit your patch. This would 
mean the problem is instead some problem in the query parser, its tests, date 
calculations, jvm handling of thai dates, something else, but not the 
locale-switching.

if the assertion is triggered, then we need to figure how why before changing 
the locale-swapping mechanism.

I ran this test 2500 times last night but i couldnt make it fail. i have a very 
small portable right now and I will need to wait till the new year to really 
look at this more...


> Use JUnit4 capabilites for more thorough Locale testing for classes deriving 
> from LocalizedTestCase
> ---------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-2122
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2122
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Other
>    Affects Versions: 3.1
>            Reporter: Erick Erickson
>            Priority: Minor
>             Fix For: 3.1
>
>         Attachments: LUCENE-2122-r2.patch, LUCENE-2122-r3.patch, 
> LUCENE-2122-r4.patch, LUCENE-2122.patch, LUCENE-2122.patch
>
>
> Use the @Parameterized capabilities of Junit4 to allow more extensive testing 
> of Locales.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to