[
https://issues.apache.org/jira/browse/LUCENE-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794593#action_12794593
]
Steven Rowe commented on LUCENE-2084:
-------------------------------------
bq. Do you think after this issue is resolved (whether it helps or doesn't
help/won't fix either way) that we should open a separate issue to work on
committing the benchmark so we have collation benchmarks for the future? Seems
like it would be good to have in the future.
Yeah, I don't know quite how to do that - the custom code wrapping
ICU/CollationKeyAnalyzer is necessary because the contrib benchmark alg format
can only handle zero-argument analyzer constructors (or those that take Version
arguments). I think it would be useful to have a general-purpose alg syntax to
handle this case without requiring custom code, and also, more generally, to
allow for the construction of aribitrary analysis pipelines without requiring
custom code (a la Solr schema). The alg parsing code is a bit dense though - I
think it could be converted to a JFlex-generated grammar to simplify this kind
of syntax extension.
Can you think of an alternate way to package this benchmark that fits with
current practice?
> remove Byte/CharBuffer wrapping for collation key generation
> ------------------------------------------------------------
>
> Key: LUCENE-2084
> URL: https://issues.apache.org/jira/browse/LUCENE-2084
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Robert Muir
> Assignee: Robert Muir
> Priority: Minor
> Fix For: 3.1
>
> Attachments: collation.benchmark.tar.bz2, LUCENE-2084.patch,
> LUCENE-2084.patch, TopTFWikipediaWords.tar.bz2
>
>
> We can remove the overhead of ByteBuffer and CharBuffer wrapping in
> CollationKeyFilter and ICUCollationKeyFilter.
> this patch moves the logic in IndexableBinaryStringTools into char[],int,int
> and byte[],int,int based methods, with the previous Byte/CharBuffer methods
> delegating to these.
> Previously, the Byte/CharBuffer methods required a backing array anyway.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
