[
https://issues.apache.org/jira/browse/LUCENE-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794662#action_12794662
]
Robert Muir commented on LUCENE-2084:
-------------------------------------
Steve, I ran the benchmark, worked like a charm. here are my numbers.
some differences are: very slow computer, newer jvm versions, etc.
Unpatched:
||Sun JVM||Language||java.text||ICU4J||KeywordAnalyzer||ICU4J Improvement||
|1.5.0_22 (32-bit)|English|31.61s|21.34s|10.66s|96%|
|1.5.0_22 (32-bit)|French|34.11s|22.59s|11.12s|100%|
|1.5.0_22 (32-bit)|German|34.59s|22.69s|10.84s|100%|
|1.5.0_22 (32-bit)|Ukrainian|50.72s|30.19s|11.09s|107%|
||Sun JVM||Language||java.text||ICU4J||KeywordAnalyzer||ICU4J Improvement||
|1.6.0_16 (32-bit)|English|26.42s|19.98s|10.11s|65%|
|1.6.0_16 (32-bit)|French|28.48s|20.14s|10.30s|85%|
|1.6.0_16 (32-bit)|German|28.41s|21.38s|9.78s|61%|
|1.6.0_16 (32-bit)|Ukrainian|40.55s|28.56s|9.70s|64%|
Patched:
||Sun JVM||Language||java.text||ICU4J||KeywordAnalyzer||ICU4J Improvement||
|1.5.0_22 (32-bit)|English|29.59s|19.33s|10.56s|117%|
|1.5.0_22 (32-bit)|French|32.38s|21.02s|10.88s|112%|
|1.5.0_22 (32-bit)|German|32.92s|20.58s|10.66s|124%|
|1.5.0_22 (32-bit)|Ukrainian|49.59s|27.05s|10.77s|138%|
||Sun JVM||Language||java.text||ICU4J||KeywordAnalyzer||ICU4J Improvement||
|1.6.0_16 (32-bit)|English|24.91s|18.28s|9.72s|77%|
|1.6.0_16 (32-bit)|French|26.30s|19.12s|10.25s|81%|
|1.6.0_16 (32-bit)|German|26.70s|19.23s|10.48s|85%|
|1.6.0_16 (32-bit)|Ukrainian|38.48s|25.66s|9.80s|81%|
Comparison:
||Sun JVM||Language||java.text improvement||ICU4J improvement||
|1.5.0_22 (32-bit)|English|10.5%|22.2%|
|1.5.0_22 (32-bit)|French|7.4%|13.6%|
|1.5.0_22 (32-bit)|German|7.1%|19.9%|
|1.5.0_22 (32-bit)|Ukrainian|2.5%|17.8%|
||Sun JVM||Language||java.text improvement||ICU4J improvement||
|1.6.0_16 (32-bit)|English|7.8%|15.8%|
|1.6.0_16 (32-bit)|French|13.7%|11.4%|
|1.6.0_16 (32-bit)|German|15.3%|33.0%|
|1.6.0_16 (32-bit)|Ukrainian|8.0%|19.4%|
> remove Byte/CharBuffer wrapping for collation key generation
> ------------------------------------------------------------
>
> Key: LUCENE-2084
> URL: https://issues.apache.org/jira/browse/LUCENE-2084
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Robert Muir
> Assignee: Robert Muir
> Priority: Minor
> Fix For: 3.1
>
> Attachments: collation.benchmark.tar.bz2, LUCENE-2084.patch,
> LUCENE-2084.patch, TopTFWikipediaWords.tar.bz2
>
>
> We can remove the overhead of ByteBuffer and CharBuffer wrapping in
> CollationKeyFilter and ICUCollationKeyFilter.
> this patch moves the logic in IndexableBinaryStringTools into char[],int,int
> and byte[],int,int based methods, with the previous Byte/CharBuffer methods
> delegating to these.
> Previously, the Byte/CharBuffer methods required a backing array anyway.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
