[ 
https://issues.apache.org/jira/browse/LUCENE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837879#action_12837879
 ] 

Michael McCandless commented on LUCENE-2282:
--------------------------------------------

Patch looks good Shai!

But I don't think we should back port to 3.0.2 -- it's non-trivial
enough that there is some risk?

As the API is now marked @lucene.internal, and it'll only be very
expert usage, I'm not as concerned as Marvin is about the risks of
even exposing this.  Also, even with flex, a good number of Lucene's
index files are not under codec control (codec only touches postings
files -- .tis, .tii, .frq, .prx for the standard codec).  But I do
agree it's not ideal that the knowledge of file extensions is split
across this class and the codec.  The IndexFileNameFilter in flex now
takes a Codec as input, to make up for that... but IndexFileNames just
has a NOTE at the top stating the limitation.


> Expose IndexFileNames as public, and make use of its methods in the code
> ------------------------------------------------------------------------
>
>                 Key: LUCENE-2282
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2282
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Shai Erera
>            Assignee: Michael McCandless
>             Fix For: 3.1
>
>         Attachments: LUCENE-2282.patch, LUCENE-2282.patch, LUCENE-2282.patch
>
>
> IndexFileNames is useful for applications that extend Lucene, an in 
> particular those who extend Directory or IndexWriter. It provides useful 
> constants and methods to query whether a certain file is a core Lucene file 
> or not. In addition, IndexFileNames should be used by Lucene's code to 
> generate segment file names, or query whether a certain file matches a 
> certain extension.
> I'll post the patch shortly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to