[ https://issues.apache.org/jira/browse/LUCENE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837988#action_12837988 ]
Marvin Humphrey commented on LUCENE-2282: ----------------------------------------- > As the API is now marked @lucene.internal, and it'll only be very > expert usage, I'm not as concerned as Marvin is about the risks of > even exposing this. Um, the only possible concerns I could have had were regarding public exposure of this API. If it's marked as internal, it's an implementation detail. Whether or not the dot is included in internal-use-only constant strings isn't something I'm going to waste a lot of time thinking about. ;) So now, not only do I really, really not care whether this goes in, I have no qualms about it either. Having users like Shai who are willing to recompile and regenerate to take advantage of experimental features is a big boon, as it allows us to test drive features before declaring them stable. Designing optimal APIs without usability testing is difficult to impossible. > Expose IndexFileNames as public, and make use of its methods in the code > ------------------------------------------------------------------------ > > Key: LUCENE-2282 > URL: https://issues.apache.org/jira/browse/LUCENE-2282 > Project: Lucene - Java > Issue Type: Improvement > Reporter: Shai Erera > Assignee: Michael McCandless > Fix For: 3.1 > > Attachments: LUCENE-2282.patch, LUCENE-2282.patch, LUCENE-2282.patch > > > IndexFileNames is useful for applications that extend Lucene, an in > particular those who extend Directory or IndexWriter. It provides useful > constants and methods to query whether a certain file is a core Lucene file > or not. In addition, IndexFileNames should be used by Lucene's code to > generate segment file names, or query whether a certain file matches a > certain extension. > I'll post the patch shortly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org