[
https://issues.apache.org/jira/browse/LUCENE-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839007#action_12839007
]
Michael McCandless commented on LUCENE-1990:
--------------------------------------------
Great progress! I think this is very close.
Airplane blocking snow drifts!? Where on earth are you anyway?
{quote}
bq. Can you add @lucene.internal to the javadocs?
Should this also be applied to package private classes? Marking those as
internal seems redundant.
{quote}
Yeah I agree package private APIs don't need the @lucene.internal...
It's very interesting that align is never a win -- I think in that
case removing it makes sense? It'll be a nice simplification.
I think we don't need to make a MutableWriter, at least before
committing? Nobody needs it now... (I think?).
Other small things:
* Can you use @lucene.internal instead of the NOTE that I had put on
the classes?
* We lost "final" in the RamUsageEstimator constants
* Did we ever test performance of the specialized (generated)
decoders using switch statements?
> Add unsigned packed int impls in oal.util
> -----------------------------------------
>
> Key: LUCENE-1990
> URL: https://issues.apache.org/jira/browse/LUCENE-1990
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Reporter: Michael McCandless
> Priority: Minor
> Attachments: LUCENE-1990-te20100122.patch,
> LUCENE-1990-te20100210.patch, LUCENE-1990-te20100212.patch,
> LUCENE-1990-te20100223.patch, LUCENE-1990-te20100226.patch,
> LUCENE-1990-te20100226b.patch, LUCENE-1990.patch,
> LUCENE-1990_PerformanceMeasurements20100104.zip, performance-te20100226.txt
>
>
> There are various places in Lucene that could take advantage of an
> efficient packed unsigned int/long impl. EG the terms dict index in
> the standard codec in LUCENE-1458 could subsantially reduce it's RAM
> usage. FieldCache.StringIndex could as well. And I think "load into
> RAM" codecs like the one in TestExternalCodecs could use this too.
> I'm picturing something very basic like:
> {code}
> interface PackedUnsignedLongs {
> long get(long index);
> void set(long index, long value);
> }
> {code}
> Plus maybe an iterator for getting and maybe also for setting. If it
> helps, most of the usages of this inside Lucene will be "write once"
> so eg the set could make that an assumption/requirement.
> And a factory somewhere:
> {code}
> PackedUnsignedLongs create(int count, long maxValue);
> {code}
> I think we should simply autogen the code (we can start from the
> autogen code in LUCENE-1410), or, if there is an good existing impl
> that has a compatible license that'd be great.
> I don't have time near-term to do this... so if anyone has the itch,
> please jump!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
