[
https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-2386:
-------------------------------
Attachment: LUCENE-2386.patch
First stab at this. Patch still missing CHANGES entry, and I haven't run all
the tests, just TestIndexWriter. With those changes it passes. One thing that I
think should be fixed is testImmediateDiskFull - if I don't add
writer.commit(), the test fails, because dir.getRecomputeActualSizeInBytes
returns 0 (no RAMFiles yet), and then the test succeeds at adding one document.
So maybe just change the test to set maxSizeInBytes to '1', always?
TestNoDeletionPolicy is not covered by this patch (should be fixed as well,
because now the number of commits is exactly N and not N+1). Will fix it
tomorrow.
Anyway, it's really late now, so hopefully some fresh eyes will look at it
while I'm away, and comment on the proposed changes. I hope I got all the
changes to the tests right.
> IndexWriter commits unnecessarily on fresh Directory
> ----------------------------------------------------
>
> Key: LUCENE-2386
> URL: https://issues.apache.org/jira/browse/LUCENE-2386
> Project: Lucene - Java
> Issue Type: Bug
> Components: Index
> Reporter: Shai Erera
> Assignee: Shai Erera
> Fix For: 3.1
>
> Attachments: LUCENE-2386.patch
>
>
> I've noticed IndexWriter's ctor commits a first commit (empty one) if a fresh
> Directory is passed, w/ OpenMode.CREATE or CREATE_OR_APPEND. This seems
> unnecessarily, and kind of brings back an autoCommit mode, in a strange way
> ... why do we need that commit? Do we really expect people to open an
> IndexReader on an empty Directory which they just passed to an IW w/
> create=true? If they want, they can simply call commit() right away on the IW
> they created.
> I ran into this when writing a test which committed N times, then compared
> the number of commits (via IndexReader.listCommits) and was surprised to see
> N+1 commits.
> Tried to change doCommit to false in IW ctor, but it got IndexFileDeleter
> jumping on me .. so the change might not be that simple. But I think it's
> manageable, so I'll try to attack it (and IFD specifically !) back :).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
