On Tue, 6 Oct 2020 23:30:22 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:
>> Hannes Wallnöfer has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now
>> contains seven commits:
>> - Merge master
>> - Address issues raised in code review:
>> - remove unused styles and method
>> - rename alternating table row styles
>> - move id attribute for tabs
>> - add line breaks in test text blocks to make them easier to read and
>> maintain
>> - Fix trailing whitespace
>> - Clean up comments and styles
>> - Restore table spacing
>> - Adapt tests to grid summaries
>> - Use CSS Grid Layout for javadoc summaries
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/script.js
> line 58:
>
>> 56: .forEach(function(elem, index) {
>> 57: elem.style.display = '';
>> 58: var isEvenRow = index % (columns * 2) < columns;
>
> OK, this line is weird. Why is the polarity of the row dependent on the
> number of columns?
Unfortunately we don't have one element per row. The number of elements per row
is equal to the number of columns,
therefore this calculation is necessary to determine the row style.
-------------
PR: https://git.openjdk.java.net/jdk/pull/253
