On Tue, 6 Oct 2020 23:31:48 GMT, Jonathan Gibbons <[email protected]> wrote:
>> Hannes Wallnöfer has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now
>> contains seven commits:
>> - Merge master
>> - Address issues raised in code review:
>> - remove unused styles and method
>> - rename alternating table row styles
>> - move id attribute for tabs
>> - add line breaks in test text blocks to make them easier to read and
>> maintain
>> - Fix trailing whitespace
>> - Clean up comments and styles
>> - Restore table spacing
>> - Adapt tests to grid summaries
>> - Use CSS Grid Layout for javadoc summaries
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/script.js
> line 89:
>
>> 87: selected.previousSibling.focus();
>> 88: e.preventDefault();
>> 89: } else if ((e.keyCode === 39 || e.keyCode === 40) &&
>> selected.nextSibling) {
>
> Can we have constants, or at least a comment for the values 37, 38, 39, 40
I'm adding comments in my next commit. We don't have immutable `const`
declarations in JS due to backwards
compatibility, so I'm not keen to add a `var` pseudo-constant.
-------------
PR: https://git.openjdk.java.net/jdk/pull/253
