On Thu, 15 Oct 2020 18:23:25 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:
>> The mechanism to add links for summary pages in the main index is >> generalized, and now includes the Constant Values >> page, the Deprecated page and the Serialized Form page, provided these pages >> have non-empty content. >> The only change to the generated output is very minor: the text of existing >> link to the "System Properties" page is >> changed to use a non-breaking space, in line with the links for "All >> Classes" and "All Packages". > > Jonathan Gibbons has updated the pull request incrementally with two > additional commits since the last revision: > > - fix whitespace typo > - move all summary pages to "Tags" category Jon, I actually liked "All Classes" and "All Packages" being in the Types and Packages categories, respectively. I think it made sense to show them there and they were easier to find and use. However, I understand it is conceptually cleaner this way and I don't want to start a bikeshedding session over it, so I give an approving review, but I would be interested in your thoughts about this. ------------- Marked as reviewed by hannesw (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/643
