On Fri, 16 Oct 2020 11:13:12 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:
>> Jonathan Gibbons has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - fix whitespace typo >> - move all summary pages to "Tags" category > > Jon, I actually liked "All Classes" and "All Packages" being in the Types and > Packages categories, respectively. I > think it made sense to show them there and they were easier to find and use. > However, I understand it is conceptually cleaner this way and I don't want to > start a bikeshedding session over it, so > I give an approving review, but I would be interested in your thoughts about > this. The only change in the latest commit is to back out the changes related to "All Classes" and "All Packages". Given that it builds and all tests still pass, I'll go with your earlier approval and integrate the change. ------------- PR: https://git.openjdk.java.net/jdk/pull/643