On Wed, 29 Sep 2021 03:04:48 GMT, Jonathan Gibbons <[email protected]> wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/tree/DCTree.java line 177:
>>
>>> 175: }
>>> 176:
>>> 177: case AUTHOR, DEPRECATED, HIDDEN, PARAM, RETURN, SEE,
>>> SERIAL, SERIAL_DATA, SERIAL_FIELD, SINCE, THROWS, UNKNOWN_BLOCK_TAG,
>>> VERSION -> {
>>
>> You added HIDDEN and merged PARAM into this case of block tags. Should we
>> also add PROVIDES and USES? If so, then we should add respective tests.
>
> Yes, and agreed.
FWIW, I'm still in two minds whether this should be a switch or overriding
methods. It's ... er, disappointing ... that the lack of support for `PROVIDES`
and `USES` didn't "automatically" show up in testing. That may suggest a lack
of coverage in the `DocTree` tests, which suggests the need for a test to check
coverage.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5510