On Wed, 29 Sep 2021 03:22:39 GMT, Jonathan Gibbons <[email protected]> wrote:
>> Yes, and agreed. > > FWIW, I'm still in two minds whether this should be a switch or overriding > methods. It's ... er, disappointing ... that the lack of support for > `PROVIDES` and `USES` didn't "automatically" show up in testing. That may > suggest a lack of coverage in the `DocTree` tests, which suggests the need > for a test to check coverage. For the sake of this review, using `switch` would be better: fewer changes, less cognitive load. Later we can think of ways of improving that code. It would be nice to structure it such that it would fail at compile time, if we forgot a case. ------------- PR: https://git.openjdk.java.net/jdk/pull/5510
