On Tue, 9 Nov 2021 18:46:54 GMT, Pavel Rappo <pra...@openjdk.org> wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains six commits:
>>
>> - Merge remote-tracking branch 'upstream/master' into
>> 8273154.JavadocTester-checker
>> - Address review comments
>> - Add, `checkAnyOf`, update `checkUnique`, reformat some comments
>> - Merge remote-tracking branch 'upstream/master' into
>> 8273154.JavadocTester-checker
>> - Merge with upstream/master
>> - JDK-8273154: Provide a JavadocTester method for non-overlapping,
>> unordered output matching
>
> test/langtools/jdk/javadoc/testJavadocTester/TestJavadocTester.java line 259:
>
>> 257: public void testOrdered() {
>> 258: messages.clear();
>> 259: // methods are listed alphabetiocally in the Summary table,
>
> Suggestion:
>
> // methods are listed alphabetically in the Summary table,
👍
> test/langtools/jdk/javadoc/testJavadocTester/TestJavadocTester.java line 332:
>
>> 330: public void testComplete_Ordered() {
>> 331: messages.clear();
>> 332: // In this following calls, the strings are specified in the
>> expected order.
>
> Should it be "these" or "the"?
Either is correct
> test/langtools/jdk/javadoc/testJavadocTester/TestJavadocTester.java line 437:
>
>> 435: .toArray(String[]::new);
>> 436: }
>> 437: }
>
> Add newline.
👍
-------------
PR: https://git.openjdk.java.net/jdk/pull/5743
