On Fri, 12 May 2023 22:07:12 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:

>> `@sealedGraph` had a mechanism to render non-sealed classes differently, but 
>> it's useless because the graph nodes are not bordered. This patch converts 
>> the non-sealed classes to be rendered in italics instead.
>> 
>> An example of `ConstantDesc`, which has a sealed hierarchy except 
>> `DynamicConstantDesc`:
>> JDK 20:
>> ![image](https://user-images.githubusercontent.com/7806504/236991678-e30c181a-cb1f-407a-b3e0-f648fe2df788.png)
>> 
>> This patch:
>> ![image](https://github.com/openjdk/jdk/assets/7806504/4fb8ec10-4f10-4902-8b9d-107b3644b2cf)
>
> @minborg You should comment on this one.   
> 
> I'm not sure that italics by itself is a good idea.

@jonathan-gibbons Can you take a look again at the revised version?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13877#issuecomment-1555269626

Reply via email to