On Tue, 16 May 2023 17:16:57 GMT, Chen Liang <li...@openjdk.org> wrote:
>> `@sealedGraph` had a mechanism to render non-sealed classes differently, but >> it's useless because the graph nodes are not bordered. This patch converts >> the non-sealed classes to be rendered in italics instead. >> >> An example of `ConstantDesc`, which has a sealed hierarchy except >> `DynamicConstantDesc`: >> JDK 20: >> ![image](https://user-images.githubusercontent.com/7806504/236991678-e30c181a-cb1f-407a-b3e0-f648fe2df788.png) >> >> This patch: >> ![image](https://github.com/openjdk/jdk/assets/7806504/4fb8ec10-4f10-4902-8b9d-107b3644b2cf) > > Chen Liang has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains three additional commits since > the last revision: > > - Use an edge and node to indicate non-sealed hierarchy > - Merge branch 'master' into fix/sealedgraph-nonsealed > - 8307652: sealed class hierarchy graph doesn't distinguish non-sealed > classes Generally, a good feature and a nice solution. I endorse @minborg's approval. Given this is in a build-time taglet for JDK documentation, the use of `<any>` is acceptable and a reasonably good solution. If this were to ever become a standard javadoc feature, we would maybe have to figure out how to localize the string, but that is not necessary here. ------------- Marked as reviewed by jjg (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/13877#pullrequestreview-1442720465 PR Comment: https://git.openjdk.org/jdk/pull/13877#issuecomment-1561898654