On Wed, 31 Jan 2024 11:50:35 GMT, psoujany <d...@openjdk.org> wrote: >> @psoujany I still get two failing tests, possibly because I updated my local >> repository by merging the current master branch before running tests. This >> PR is based on a very outdated branch, so we should definitely merge the >> master branch before integrating. The failing tests I get on my up-to-date >> branch are these: >> >> jdk/javadoc/doclet/testPreview/TestPreview.java >> jdk/javadoc/doclet/testSpecTag/TestSpecTag.java > > @hns I've updated my branch and modified the failing tests. Now all tests > seems passing with the changes. Thank you.
Thanks @psoujany, this looks good now. Although `script.js` only requires a very small change to set the `aria-labelledby` attribute in the new element, I unfortunately detected an additional bug where the attribute is set to the wrong value when switching back to the default tab. I'm currently deciding whether to fix this in this PR or file a new issue. ------------- PR Comment: https://git.openjdk.org/jdk/pull/16148#issuecomment-1919294079
